Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate image list #2615

Merged
merged 1 commit into from
Aug 27, 2024
Merged

feat: migrate image list #2615

merged 1 commit into from
Aug 27, 2024

Commits on Aug 27, 2024

  1. feat: migrate image list (#2615)

    <!--
    Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
    and how it affects the users and other developers.
    -->
    
    ### This PR resolves [#2586 ](#2586) issue
    ### TL;DR
    
    migrate ImageList
    
    ###  Why make this change?
    
    To migrate from lit component to react component
    
    ### What changed?
    
    - ImageInstallModal
        - Component that install images
        - I deselected the rows when clicking the install button in the modal because I felt the flow of deselecting the rows was more natural, whereas before it would not deselect the rows.
        - The newly added phrases are written in en and ko only
        - However, I didn't proceed with replacing "download" with "install". This was because there were more download phrases than I thought, and I thought it might be more confusing if I replaced a lot of them
    
    - ImageList
        - I used suspense to prevent the entire screen from loading when the image list is first rendered
    
    - ManageAppsModal, ManageImageResourceLimitModal
        - I modified it because it's called from a React component, not a lit component.
        - Implemented the getServicePorts function in ManageAppsModal without passing service port as a prop
    
    - ResourceNumber
        - I added ranges via the range and max properties ( ex 1~∞ Core )
        - The ResourceNumber component made rendering the table too slow, so I used Memo
    
    ### How to test?
    
    - imageList
    1. enter the environment page
    2. select the row
    3. sort the column
    
    - ManageImageResourceLimitModal
    1. click button
    3. change resource
    4. click Okay button
    5. check if the resource has changed
    
    - ManageAppsModal
    1. click button
    2. add port
    3. delete port
    4. check if the ports has changed
    
    - ImageInstallModal
    1. select uninstalled images
    2. click install button
    3. check uninstalled images info
    4. click install button and check if an notification appears
    
    1. select installed images
    2. check warn message
    
    1. select uninstalled images and installed images
    2. check exclude message
    gahyuun committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    7156dd4 View commit details
    Browse the repository at this point in the history