fix: display only active endpoints in EndpointSelect #2718
Merged
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.42% (-0% 🔻) |
337/6220 |
| 🔴 | Branches | 4.99% (-0% 🔻) |
214/4290 |
| 🔴 | Functions | 3.08% | 63/2045 |
| 🔴 | Lines | 5.32% (-0% 🔻) |
323/6075 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / EndpointSelect.tsx |
0% | 0% (-100% 🔻) |
0% | 0% |
Test suite run success
90 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from 53ce7b4
Merge activity
|
**Changes:** This PR enhances the `EndpointSelect` component by adding support for filtering endpoints based on their lifecycle stage. The main changes include: 1. Importing the `useSuspendedBackendaiClient` hook. 2. Adding a `filter` parameter to the `EndpointSelectQuery`. 3. Implementing a conditional filter based on the client's support for the 'endpoint-lifecycle-stage-filter' feature. **Rationale:** The addition of the lifecycle stage filter allows for more precise endpoint selection, showing only endpoints in the "created" stage when supported by the client. This improves the user experience by presenting a more relevant list of endpoints. **Effects:** - Users will see a filtered list of endpoints in the "created" stage when using a client that supports this feature. - Developers can now leverage the new filter parameter in the `EndpointSelectQuery` for more flexible endpoint querying.
agatha197
force-pushed
the
fix/display-only-active-endpoints-for-llmchat
branch
from
26d226b
to
53ce7b4
Compare
graphite-app
bot
deleted the
fix/display-only-active-endpoints-for-llmchat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR enhances the
EndpointSelectcomponent by adding support for filtering endpoints based on their lifecycle stage. The main changes include:useSuspendedBackendaiClienthook.filterparameter to theEndpointSelectQuery.Rationale:
The addition of the lifecycle stage filter allows for more precise endpoint selection, showing only endpoints in the "created" stage when supported by the client. This improves the user experience by presenting a more relevant list of endpoints.
Effects:
EndpointSelectQueryfor more flexible endpoint querying.