fix: ensure valid accelerator type #2729
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR resolves the same problem as #2721 but via a different approach.
Changes:
This PR ensures a valid accelerator type when the Resource group is changed. Additionally, this PR refactors the usage of resource slot details across multiple components. The main changes include:
ensureValidAcceleratorType
whenupdateAllocationPresetBasedOnResourceGroup
is called.ensureValidAcceleratorType
function now uses the response from/func/config/resource-slots/details?sgroup=ooooo
.useResourceSlotsDetails
hook to return an object with named properties instead of an array.resourceSlotsDetails
withmergedResourceSlots
throughout the codebase.useResourceSlotsDetails
hook.