fix: value handling of DynamicUnitInputNumberWithSlider #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.32% (-0.01% 🔻) |
340/6388 |
| 🔴 | Branches | 4.82% (-0% 🔻) |
214/4442 |
| 🔴 | Functions | 2.99% (-0% 🔻) |
63/2104 |
| 🔴 | Lines | 5.22% (-0.01% 🔻) |
326/6241 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / DynamicUnitInputNumberWithSlider.tsx |
4% (-1% 🔻) |
0% | 0% | 4.55% (-1.34% 🔻) |
Test suite run success
90 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from f23da9d
ironAiken2
reviewed
Oct 2, 2024
| value={ | ||
| isMinOversMaxValue(_.parseInt(min), _.parseInt(max)) ? '0m' : value | ||
| } | ||
| value={value} |
There was a problem hiding this comment.
Doesn't DynamicUnitInputNumber require separation for isMinOversMaxValue?
Suggested change
| value={value} | |
| value={isMinOversMaxValue ? '0g' : value} |
ironAiken2
requested changes
Oct 2, 2024
|
🎥 Video uploaded on Graphite:
|
yomybaby
force-pushed
the
fix/dynamic-unit-input-number-with-slider-controllable
branch
from
0ee40a8
to
7366722
Compare
ironAiken2
requested changes
Oct 2, 2024
yomybaby
force-pushed
the
fix/dynamic-unit-input-number-with-slider-controllable
branch
from
7366722
to
a16b196
Compare
|
There is a mistake. I change |
Merge activity
|
**Changes:** This PR fixes and enhances the `DynamicUnitInputNumberWithSlider` component by improving its value handling: 1. Update Input behavior (fix bug and improve UX): - set the controllable value always. 1. Updated slider behavior: - Set value to 0 and disable slider and hide tooltip when min value exceeds max value - Added `filterOutInvalidMarks` function to remove marks that fall outside the valid range(min~ max). 1. Removed dependency on external `isMinOversMaxValue` function from `ResourceAllocationFormItems` Addtionally this PR adds new stories: - "Greater min than max" to demonstrate behavior when min value exceeds max value - "Extra marks" to show custom marks on the slider - "Extra marks with greater min than max" combining both scenarios **Rationale:** These changes improve the component's robustness and flexibility, handling edge cases and providing better visual feedback to users. **Effects:** - Users will see more consistent behavior when min/max values are set incorrectly - Developers can now add custom marks to the slider and test various scenarios using the new stories
yomybaby
force-pushed
the
fix/dynamic-unit-input-number-with-slider-controllable
branch
from
a16b196
to
f23da9d
Compare
graphite-app
bot
deleted the
fix/dynamic-unit-input-number-with-slider-controllable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR fixes and enhances the
DynamicUnitInputNumberWithSlidercomponent by improving its value handling:filterOutInvalidMarksfunction to remove marks that fall outside the valid range(min~ max).isMinOversMaxValuefunction fromResourceAllocationFormItemsAddtionally this PR adds new stories:
Rationale:
These changes improve the component's robustness and flexibility, handling edge cases and providing better visual feedback to users.
Effects: