feat: User setting for the classic session launcher #2733
Merged
+79
−139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
agatha197
force-pushed
the
feature/user-setting-for-classic-launcher
branch
from
6b1b10a
to
8e8623a
Compare
YEONFEEL96
requested changes
Oct 4, 2024
agatha197
force-pushed
the
feat/session-owner-setter-in-neo
branch
from
c1f51bd
to
20aff25
Compare
agatha197
force-pushed
the
feature/user-setting-for-classic-launcher
branch
from
8e8623a
to
7dddf3e
Compare
agatha197
force-pushed
the
feature/user-setting-for-classic-launcher
branch
2 times, most recently
from
98bcf48
to
6ec5e97
Compare
yomybaby
changed the base branch from
feat/session-owner-setter-in-neo
to
graphite-base/2733
yomybaby
force-pushed
the
graphite-base/2733
branch
from
20aff25
to
c9176e3
Compare
yomybaby
force-pushed
the
feature/user-setting-for-classic-launcher
branch
from
6ec5e97
to
dd71816
Compare
yomybaby
force-pushed
the
feature/user-setting-for-classic-launcher
branch
from
dd71816
to
dab9423
Compare
agatha197
force-pushed
the
feature/user-setting-for-classic-launcher
branch
from
dab9423
to
ed626a7
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.29% (+0.01% 🔼) |
340/6424 |
| 🔴 | Branches | 4.78% (+0.02% 🔼) |
214/4475 |
| 🔴 | Functions | 2.98% (+0.01% 🔼) |
63/2116 |
| 🔴 | Lines | 5.19% (+0.01% 🔼) |
326/6276 |
Test suite run success
90 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from bbd6e18
Merge activity
|
# Remove Neo Session Launcher Switch and Introduce Classic Session Launcher Option This PR removes the Neo Session Launcher switch alert and introduces a new "Classic Session Launcher" option in user settings. It simplifies the session launcher selection process and improves the user experience. **Changes:** 1. Removed `NeoSessionLauncherSwitchAlert` component and its references. 2. Replaced `use_2409_session_launcher` setting with `classic_session_launcher`. 3. Updated `UserSettingsPage` to include a new checkbox for the Classic Session Launcher option. 4. Modified `ImportAndRunPage` and session launcher logic to use the new `classic_session_launcher` setting. **Screenshots:** 
agatha197
force-pushed
the
feature/user-setting-for-classic-launcher
branch
from
ed626a7
to
bbd6e18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Neo Session Launcher Switch and Introduce Classic Session Launcher Option
This PR removes the Neo Session Launcher switch alert and introduces a new "Classic Session Launcher" option in user settings. It simplifies the session launcher selection process and improves the user experience.
Changes:
NeoSessionLauncherSwitchAlertcomponent and its references.use_2409_session_launchersetting withclassic_session_launcher.UserSettingsPageto include a new checkbox for the Classic Session Launcher option.ImportAndRunPageand session launcher logic to use the newclassic_session_launchersetting.Screenshots: