Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FR-534): introduce NEO style Tabs and RadioGroup #3139

Merged
merged 1 commit into from
Feb 21, 2025
Merged

feat(FR-534): introduce NEO style Tabs and RadioGroup #3139

merged 1 commit into from
Feb 21, 2025
+265 −139

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Feb 11, 2025 •
edited
Loading

resolves #3182 (FR-534)

image.png
resolves #3182 (FR-534)

Introduces new UI components and enhances existing ones to improve visual consistency and user experience:

  • Added BAIRadioGroup component with custom styling for radio buttons
  • Added BAITabs component with customized tab styling and borders
  • Enhanced BAICard with divider control and styling options
  • Updated SessionStatusTag with improved tooltip and border radius
  • Refactored EndpointList from a page to a reusable component
  • Enhanced table headers with tooltips instead of multi-line text
  • Applied consistent spacing and styling across components
  • Updated serving page layout and padding

@github-actions github-actions bot added the size:L 100~500 LoC label Feb 11, 2025
@yomybaby Graphite App
Copy link
Member Author

yomybaby commented Feb 11, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements
4.62% (-0.01% 🔻)
 404/8738
🔴 Branches
4.01% (-0% 🔻)
 240/5982
🔴 Functions
2.8% (-0% 🔻)
 79/2819
🔴 Lines
4.55% (-0.01% 🔻)
 389/8549
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🔴
... / BAIRadioGroup.tsx
 0% 100% 0% 0%
🔴
... / BAITabs.tsx
 0% 100% 0% 0%
🔴
... / EndpointList.tsx
 0% 0% 0% 0%

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from aa3524c

@yomybaby yomybaby force-pushed the feature/baitabs-and-bairadiogroup branch 3 times, most recently from 2d39a5c to 0a66706 Compare February 13, 2025 14:44
@yomybaby yomybaby mentioned this pull request Feb 13, 2025
Merged
@yomybaby yomybaby force-pushed the feature/baitabs-and-bairadiogroup branch from 0a66706 to 17fade8 Compare February 16, 2025 23:01
@yomybaby yomybaby changed the title feat: introduce NEO style Tabs and RadioGroup feat(FR-534): introduce NEO style Tabs and RadioGroup Feb 17, 2025
@yomybaby yomybaby force-pushed the feature/baitabs-and-bairadiogroup branch from 17fade8 to 2f135b1 Compare February 17, 2025 04:52
@yomybaby yomybaby marked this pull request as ready for review February 17, 2025 04:53
agatha197
agatha197 requested changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts.

@yomybaby yomybaby force-pushed the feature/baitabs-and-bairadiogroup branch from 2f135b1 to 4fabfd4 Compare February 18, 2025 02:18
@yomybaby yomybaby requested a review from agatha197 February 18, 2025 02:18
@yomybaby Graphite App
Copy link
Member Author

@agatha197 resolved! 😀

agatha197
agatha197 requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you apply the status styles to the endpoint too?
image.png

@yomybaby yomybaby force-pushed the feature/baitabs-and-bairadiogroup branch from 4fabfd4 to 13be49a Compare February 20, 2025 05:27
@yomybaby yomybaby mentioned this pull request Feb 20, 2025
Draft
5 tasks
@yomybaby yomybaby requested a review from agatha197 February 20, 2025 05:55
@yomybaby yomybaby force-pushed the feature/baitabs-and-bairadiogroup branch from 13be49a to 03a9536 Compare February 20, 2025 05:55
agatha197
agatha197 requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There're many radio group haha.

  1. agent page
    image.png
  2. User Credentials & Policies

image.png

image.png

  1. agent summary

image.png

Status styles

  1. agent page (But it's a double tag, so you can leave it as it is)

image.png

  1. serving page

image.png

@yomybaby yomybaby force-pushed the feature/baitabs-and-bairadiogroup branch from 03a9536 to 585d5dc Compare February 21, 2025 03:05
@yomybaby yomybaby requested a review from agatha197 February 21, 2025 03:07
agatha197
agatha197 approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 21, 2025 •
edited
Loading

Merge activity

@yomybaby
feat(FR-534): introduce NEO style Tabs and RadioGroup (#3139)
aa3524c 
resolves #3182 (FR-534)

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/XqC2uNFuj0wg8I60sMUh/8b9d95ff-9578-41d9-9ca5-9c1bc6ee0068.png)
resolves #3182 (FR-534)

Introduces new UI components and enhances existing ones to improve visual consistency and user experience:

- Added BAIRadioGroup component with custom styling for radio buttons
- Added BAITabs component with customized tab styling and borders
- Enhanced BAICard with divider control and styling options
- Updated SessionStatusTag with improved tooltip and border radius
- Refactored EndpointList from a page to a reusable component
- Enhanced table headers with tooltips instead of multi-line text
- Applied consistent spacing and styling across components
- Updated serving page layout and padding
@graphite-app graphite-app bot force-pushed the feature/baitabs-and-bairadiogroup branch from 585d5dc to aa3524c Compare February 21, 2025 04:12
@graphite-app graphite-app bot merged commit aa3524c into main Feb 21, 2025
8 checks passed
@graphite-app graphite-app bot deleted the feature/baitabs-and-bairadiogroup branch February 21, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agatha197 agatha197 agatha197 approved these changes

@ironAiken2 ironAiken2 Awaiting requested review from ironAiken2

Assignees

@yomybaby yomybaby

Labels
size:L 100~500 LoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce NEO style Tabs and RadioGroup
2 participants
@yomybaby @agatha197