-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FR-536): Move LLM Playground to on the top menu #3195
feat(FR-536): Move LLM Playground to on the top menu #3195
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 4.62% (+0% 🔼) |
401/8675 |
🔴 | Branches | 4% (+0% 🔼) |
239/5978 |
🔴 | Functions | 2.79% (+0% 🔼) |
78/2792 |
🔴 | Lines | 4.55% (+0% 🔼) |
386/8488 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🔴 | pages/ChatPage.tsx | 0% | 0% | 0% | 0% |
🔴 | ... / ScrollBottomHandlerButton.tsx |
0% | 0% | 0% | 0% |
🔴 | ... / ChatMessageList.tsx |
0% | 0% | 0% | 0% |
🔴 | ... / ChatSender.tsx |
0% | 0% | 0% | 0% |
🔴 | ... / ModelSelect.tsx |
0% | 0% | 0% | 0% |
🔴 | ... / CopyButton.tsx |
0% | 0% | 0% | 0% |
🔴 | ... / ChatMessage.tsx |
0% | 0% | 0% | 0% |
🔴 | ... / ChatUIModal.tsx |
0% | 0% | 0% | 0% |
🔴 | ... / EndpointLLMChatCard.tsx |
0% | 0% | 0% | 0% |
🔴 | ... / VirtualChatMessageList.tsx |
0% | 0% | 0% | 0% |
🔴 | ... / LLMChatCard.tsx |
0% | 0% | 0% | 0% |
🔴 | ... / ChatMessageContent.tsx |
0% | 0% | 0% | 0% |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from d54d1c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move the Chat menu after "Serving(모델 서빙)".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove "LLM playground" tab on ServingPage.tsx
.
a1efa52
to
cc5917c
Compare
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the eslint errors. Let's remove unused variables.
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Than you for your contribution.
Merge activity
|
resolves #NNN (FR-536) Adds a dedicated Chat page accessible from the main navigation menu. The chat functionality has been moved from the Serving page to its own route at /chat. This change includes: - New Chat menu item in the main navigation sidebar - Relocated chat components from lablupTalkativotUI to a dedicated Chat directory - Added chat-related translations for all supported languages - Simplified the initial chat interface to start with a single chat window instead of two
bd19690
to
d54d1c4
Compare
resolves #NNN (FR-536)
Adds a dedicated Chat page accessible from the main navigation menu. The chat functionality has been moved from the Serving page to its own route at /chat. This change includes: