Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-536): Move LLM Playground to on the top menu #3195

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

ragingwind
Copy link
Contributor

@ragingwind ragingwind commented Feb 18, 2025

resolves #NNN (FR-536)

Adds a dedicated Chat page accessible from the main navigation menu. The chat functionality has been moved from the Serving page to its own route at /chat. This change includes:

  • New Chat menu item in the main navigation sidebar
  • Relocated chat components from lablupTalkativotUI to a dedicated Chat directory
  • Added chat-related translations for all supported languages
  • Simplified the initial chat interface to start with a single chat window instead of two

@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:L 100~500 LoC labels Feb 18, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ragingwind ragingwind changed the title Move LLM Playgrount to on the top-level feat(FR-536): Move LLM Playground to on the top menu Feb 18, 2025
Copy link

github-actions bot commented Feb 18, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.62% (+0% 🔼)
401/8675
🔴 Branches
4% (+0% 🔼)
239/5978
🔴 Functions
2.79% (+0% 🔼)
78/2792
🔴 Lines
4.55% (+0% 🔼)
386/8488
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴 pages/ChatPage.tsx 0% 0% 0% 0%
🔴
... / ScrollBottomHandlerButton.tsx
0% 0% 0% 0%
🔴
... / ChatMessageList.tsx
0% 0% 0% 0%
🔴
... / ChatSender.tsx
0% 0% 0% 0%
🔴
... / ModelSelect.tsx
0% 0% 0% 0%
🔴
... / CopyButton.tsx
0% 0% 0% 0%
🔴
... / ChatMessage.tsx
0% 0% 0% 0%
🔴
... / ChatUIModal.tsx
0% 0% 0% 0%
🔴
... / EndpointLLMChatCard.tsx
0% 0% 0% 0%
🔴
... / VirtualChatMessageList.tsx
0% 0% 0% 0%
🔴
... / LLMChatCard.tsx
0% 0% 0% 0%
🔴
... / ChatMessageContent.tsx
0% 0% 0% 0%

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from d54d1c4

@ragingwind ragingwind requested a review from yomybaby February 18, 2025 04:51
@ragingwind ragingwind marked this pull request as ready for review February 18, 2025 04:51
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move the Chat menu after "Serving(모델 서빙)".

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove "LLM playground" tab on ServingPage.tsx.

@yomybaby yomybaby requested a review from agatha197 February 19, 2025 08:22
@yomybaby yomybaby force-pushed the 02-18-move_llm_playgrount_to_on_the_top-level branch from a1efa52 to cc5917c Compare February 19, 2025 09:19
Copy link
Contributor Author

Fixed

Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the eslint errors. Let's remove unused variables.

Copy link
Contributor Author

Fixed

Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Than you for your contribution.

Copy link

graphite-app bot commented Feb 20, 2025

Merge activity

resolves #NNN (FR-536)

Adds a dedicated Chat page accessible from the main navigation menu. The chat functionality has been moved from the Serving page to its own route at /chat. This change includes:

- New Chat menu item in the main navigation sidebar
- Relocated chat components from lablupTalkativotUI to a dedicated Chat directory
- Added chat-related translations for all supported languages
- Simplified the initial chat interface to start with a single chat window instead of two
@graphite-app graphite-app bot force-pushed the 02-18-move_llm_playgrount_to_on_the_top-level branch from bd19690 to d54d1c4 Compare February 20, 2025 05:17
@graphite-app graphite-app bot merged commit d54d1c4 into main Feb 20, 2025
7 checks passed
@graphite-app graphite-app bot deleted the 02-18-move_llm_playgrount_to_on_the_top-level branch February 20, 2025 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:ux UI / UX issue. size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants