Skip to content

Commit

Permalink
fix: Reflect feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
@jopemachine
jopemachine committed Feb 13, 2025
1 parent 4eef923 commit 800cac2
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 45 deletions.
38 changes: 19 additions & 19 deletions docs/manager/graphql-reference/schema.graphql
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1976,7 +1976,7 @@ type Mutations {

"""Added in 25.3.0."""
modify_container_registry_node_v2(

Check notice on line 1978 in docs/manager/graphql-reference/schema.graphql

View workflow job for this annotation

GitHub Actions / GraphQL Inspector

Field 'modify_container_registry_node_v2' was added to object type 'Mutations' 

Field 'modify_container_registry_node_v2' was added to object type 'Mutations'
"""Object id. Can be either global id or object id. Added in 25.03.0."""
"""Object id. Can be either global id or object id. Added in 25.3.0."""
id: String!

"""Added in 25.3.0."""
Expand Down Expand Up @@ -2773,31 +2773,31 @@ type CreateContainerRegistryNodeV2 {

"""Added in 25.3.0."""
input CreateContainerRegistryNodeInputV2 {

Check notice on line 2775 in docs/manager/graphql-reference/schema.graphql

View workflow job for this annotation

GitHub Actions / GraphQL Inspector

Type 'CreateContainerRegistryNodeInputV2' was added 

Type 'CreateContainerRegistryNodeInputV2' was added
"""Added in 24.09.0."""
"""Added in 25.3.0."""
url: String!

"""Added in 24.09.0."""
"""Added in 25.3.0."""
type: ContainerRegistryTypeField!

"""Added in 24.09.0."""
"""Added in 25.3.0."""
registry_name: String!

"""Added in 24.09.0."""
"""Added in 25.3.0."""
is_global: Boolean

"""Added in 24.09.0."""
"""Added in 25.3.0."""
project: String

"""Added in 24.09.0."""
"""Added in 25.3.0."""
username: String

"""Added in 24.09.0."""
"""Added in 25.3.0."""
password: String

"""Added in 24.09.0."""
"""Added in 25.3.0."""
ssl_verify: Boolean

"""Added in 24.09.3."""
"""Added in 25.3.0."""
extra: JSONString

"""Added in 25.3.0."""
Expand All @@ -2820,31 +2820,31 @@ type ModifyContainerRegistryNodeV2 {

"""Added in 25.3.0."""
input ModifyContainerRegistryNodeInputV2 {

Check notice on line 2822 in docs/manager/graphql-reference/schema.graphql

View workflow job for this annotation

GitHub Actions / GraphQL Inspector

Type 'ModifyContainerRegistryNodeInputV2' was added 

Type 'ModifyContainerRegistryNodeInputV2' was added
"""Added in 24.09.0."""
"""Added in 25.3.0."""
url: String

"""Added in 24.09.0."""
"""Added in 25.3.0."""
type: ContainerRegistryTypeField

"""Added in 24.09.0."""
"""Added in 25.3.0."""
registry_name: String

"""Added in 24.09.0."""
"""Added in 25.3.0."""
is_global: Boolean

"""Added in 24.09.0."""
"""Added in 25.3.0."""
project: String

"""Added in 24.09.0."""
"""Added in 25.3.0."""
username: String

"""Added in 24.09.0."""
"""Added in 25.3.0."""
password: String

"""Added in 24.09.0."""
"""Added in 25.3.0."""
ssl_verify: Boolean

"""Added in 24.09.3."""
"""Added in 25.3.0."""
extra: JSONString

"""Added in 25.3.0."""
Expand Down
45 changes: 19 additions & 26 deletions src/ai/backend/manager/models/gql_models/container_registry_v2.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import logging
import uuid
from collections.abc import Sequence
from typing import TYPE_CHECKING, Any, TypeAlias

import graphene
Expand All @@ -28,12 +27,6 @@

log = BraceStyleAdapter(logging.getLogger(__spec__.name)) # type: ignore

__all__: Sequence[str] = (
"CreateContainerRegistryNodeV2",
"ModifyContainerRegistryNodeV2",
"DeleteContainerRegistryNodeV2",
)


WhereClauseType: TypeAlias = (
sa.sql.expression.BinaryExpression | sa.sql.expression.BooleanClauseList
Expand All @@ -45,15 +38,15 @@ class CreateContainerRegistryNodeInputV2(graphene.InputObjectType):
Added in 25.3.0.
"""

url = graphene.String(required=True, description="Added in 24.09.0.")
type = ContainerRegistryTypeField(required=True, description="Added in 24.09.0.")
registry_name = graphene.String(required=True, description="Added in 24.09.0.")
is_global = graphene.Boolean(description="Added in 24.09.0.")
project = graphene.String(description="Added in 24.09.0.")
username = graphene.String(description="Added in 24.09.0.")
password = graphene.String(description="Added in 24.09.0.")
ssl_verify = graphene.Boolean(description="Added in 24.09.0.")
extra = graphene.JSONString(description="Added in 24.09.3.")
url = graphene.String(required=True, description="Added in 25.3.0.")
type = ContainerRegistryTypeField(required=True, description="Added in 25.3.0.")
registry_name = graphene.String(required=True, description="Added in 25.3.0.")
is_global = graphene.Boolean(description="Added in 25.3.0.")
project = graphene.String(description="Added in 25.3.0.")
username = graphene.String(description="Added in 25.3.0.")
password = graphene.String(description="Added in 25.3.0.")
ssl_verify = graphene.Boolean(description="Added in 25.3.0.")
extra = graphene.JSONString(description="Added in 25.3.0.")
allowed_groups = AllowedGroups(description="Added in 25.3.0.")


Expand Down Expand Up @@ -116,15 +109,15 @@ class ModifyContainerRegistryNodeInputV2(graphene.InputObjectType):
Added in 25.3.0.
"""

url = graphene.String(description="Added in 24.09.0.")
type = ContainerRegistryTypeField(description="Added in 24.09.0.")
registry_name = graphene.String(description="Added in 24.09.0.")
is_global = graphene.Boolean(description="Added in 24.09.0.")
project = graphene.String(description="Added in 24.09.0.")
username = graphene.String(description="Added in 24.09.0.")
password = graphene.String(description="Added in 24.09.0.")
ssl_verify = graphene.Boolean(description="Added in 24.09.0.")
extra = graphene.JSONString(description="Added in 24.09.3.")
url = graphene.String(description="Added in 25.3.0.")
type = ContainerRegistryTypeField(description="Added in 25.3.0.")
registry_name = graphene.String(description="Added in 25.3.0.")
is_global = graphene.Boolean(description="Added in 25.3.0.")
project = graphene.String(description="Added in 25.3.0.")
username = graphene.String(description="Added in 25.3.0.")
password = graphene.String(description="Added in 25.3.0.")
ssl_verify = graphene.Boolean(description="Added in 25.3.0.")
extra = graphene.JSONString(description="Added in 25.3.0.")
allowed_groups = AllowedGroups(description="Added in 25.3.0.")


Expand All @@ -139,7 +132,7 @@ class Meta:
class Arguments:
id = graphene.String(
required=True,
description="Object id. Can be either global id or object id. Added in 25.03.0.",
description="Object id. Can be either global id or object id. Added in 25.3.0.",
)
props = ModifyContainerRegistryNodeInputV2(required=True, description="Added in 25.3.0.")

Expand Down

0 comments on commit 800cac2

Please sign in to comment.