feat: try-start model service API
#1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:client
|
@kyujin-cho please resolve conflicts from main branch. Seems like there are lots of changes in api/service module. |
10 tasks
lizable
reviewed
Jan 18, 2024
| | SessionTerminatedEvent | ||
| | ModelServiceStatusEvent, | ||
| ) -> None: | ||
| await reporter.update(message=json.dumps({"event": event.name})) |
There was a problem hiding this comment.
@kyujin-cho Could you add session_id on every event?
lizable
requested changes
Jan 18, 2024
There was a problem hiding this comment.
It would be useful to send session_id when every event is sent. Could you change message data according to comments above @kyujin-cho ?
| case SessionTerminatedEvent() | SessionCancelledEvent(): | ||
| terminated_event.set() | ||
| case ModelServiceStatusEvent(): | ||
| await reporter.update(message=event.new_status.value) |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
/services/_/tryAPI.Checklist: (if applicable)