-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change type name of AsyncNode to Node #1757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it Relay
compiler that throws an error?
changes/1757.fix.md
Outdated
@@ -0,0 +1 @@ | |||
Change type name of AsyncNode to Node since React compiler use it to determine relay node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change type name of AsyncNode to Node since React compiler use it to determine relay node. | |
Change type name of AsyncNode to Node since Relay compiler use it to determine relay node. |
Tested with: // ModelCardModal.tsx
const model_card = useFragment(
graphql`
fragment ModelCardModalFragment on ModelCard
@refetchable(queryName: "ModelCardModalRefetchQuery") {
id
name
}
`,
modelCardModalFrgmt,
); Refs: https://relay.dev/graphql/objectidentification.htm#sec-Node-Interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Thank you.
React compiler use the name of type whether it is
Node
or not.It raises error if the name is not
Node
.Checklist: (if applicable)