feat: ensure serializability for whole logging data passed to the zmq #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyujin-cho
added
type:refactor
github-actions
bot
added
comp:agent
.feature.md -> 1759.feature.md
kyujin-cho
removed
the
impact:invisible
achimnol
approved these changes
Apr 8, 2024
achimnol
added a commit
that referenced
this pull request
Apr 8, 2024
…#1759) Backported-from: main (24.09) Backported-to: 24.03 Co-authored-by: Joongi Kim <[email protected]>
achimnol
added a commit
that referenced
this pull request
Apr 8, 2024
…#1759) Backported-from: main (24.09) Backported-to: 23.09 Co-authored-by: Joongi Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #1598. I understand that the ideal approach to break through this issue is to simply override
formatException()method for all custom formatters. But since some of the upstream formatters just simply ignores their ownformatException()and instead directly callslogging.Formatter.formatException(), monkey patching target method was the only choice.Checklist: (if applicable)