feat(BA-648): Create KVS Interface #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
comp:common
racheliee
changed the title
changes/3636.feature.md
Outdated
| @@ -0,0 +1 @@ | |||
| Create KVS Interface | |||
There was a problem hiding this comment.
We are currently using towncrier based on the PR number.
Filename should be 3645.feature.md.
There was a problem hiding this comment.
oh oops gotcha thank you!!
src/ai/backend/common/etcd.py
Outdated
| ready_event: Optional[CondVar] = None, | ||
| cleanup_event: Optional[CondVar] = None, | ||
| wait_timeout: Optional[float] = None, | ||
| ) -> AsyncGenerator[Union["QueueSentinel", "Event"], None]: |
There was a problem hiding this comment.
Please do not use the class as a string.
HyeockJinKim
approved these changes
Feb 11, 2025
Yaminyam
pushed a commit
that referenced
this pull request
Feb 12, 2025
Yaminyam
pushed a commit
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3636 (BA-648)
This PR creates an interface for the Key-Value Store (KVS) that is being used. It is foundational work to implement Raftify's KVS in the future.
This does not affect how
AsyncEtcdis being used in any way; none of theAsyncEtcdfunctions were changed.Checklist: (if applicable)
docsdirectory