Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stabilize ZMQ RPC auth and malformed packet handling #27

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

achimnol
Copy link
Member

  • fix: Continue the recv loop even when there are unhandled exceptions
  • fix: Use the same timeout mechanism to pyzmq's own auth test cases

@achimnol achimnol added the bug Something isn't working label Feb 28, 2024
@achimnol achimnol self-assigned this Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.36%. Comparing base (d0461d0) to head (581f450).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   97.36%   97.36%           
=======================================
  Files           4        4           
  Lines         304      304           
=======================================
  Hits          296      296           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achimnol achimnol changed the title fix: Stabilize ZMQ RPC authentication fix: Stabilize ZMQ RPC auth and malformed packet handling Feb 28, 2024
@achimnol achimnol merged commit 1bf72f5 into main Feb 28, 2024
14 checks passed
@achimnol achimnol deleted the fix/stabilize-zmq-rpc-auth branch February 28, 2024 16:58
achimnol added a commit that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant