Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement config loader #143

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Oct 4, 2024

Implement Config type direct loading from a configuration file using the config crate.

Also resolves #138.

Thanks to @jyc0011!
Ref: #142.

@jopemachine jopemachine added the refactoring Rewrite something in better way while keeping the same functionality label Oct 4, 2024
Copy link

cla-assistant bot commented Oct 4, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jopemachine
❌ jyc0011
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
Copy link

cla-assistant bot commented Oct 4, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jopemachine
❌ jyc0011
You have signed the CLA already but the status is still pending? Let us recheck it.

@jopemachine jopemachine added the feature New feature or request label Oct 4, 2024
@jopemachine jopemachine merged commit fabc961 into main Oct 4, 2024
1 of 2 checks passed
@jopemachine jopemachine added the ossca-24 OSS Contribution Academy mentee's contributions. label Oct 7, 2024
@jopemachine jopemachine self-assigned this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request ossca-24 OSS Contribution Academy mentee's contributions. refactoring Rewrite something in better way while keeping the same functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the build_config() in the example code with config.toml
2 participants