Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: message notification #4350

Merged
merged 16 commits into from
Nov 29, 2023
Merged

feat: message notification #4350

merged 16 commits into from
Nov 29, 2023

Conversation

bxy4543
Copy link
Member

@bxy4543 bxy4543 commented Nov 27, 2023

two serious change:
add get user func for db interface
controllers/pkg/database/interface.go
optimize notification struct
controllers/pkg/notification/api/v1/notification_types.go

Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Nov 27, 2023

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1036
✅ Successful 368
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 667
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 27, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (552dac8) 65.45% compared to head (fea5e16) 65.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4350   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bxy4543 bxy4543 force-pushed the message_notification branch from d29f0f6 to fea5e16 Compare November 29, 2023 06:00
@bxy4543 bxy4543 merged commit 3eb6823 into labring:main Nov 29, 2023
69 checks passed
@bxy4543 bxy4543 deleted the message_notification branch November 29, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants