-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: message notification #4350
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whoa! Easy there, Partner!This PR is too big. Please break it up into smaller PRs. |
🤖 Generated by lychee actionSummary
Full action output |
Apply Sweep Rules to your PR?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4350 +/- ##
=======================================
Coverage 65.45% 65.45%
=======================================
Files 8 8
Lines 660 660
=======================================
Hits 432 432
Misses 180 180
Partials 48 48 ☔ View full report in Codecov by Sentry. |
bxy4543
force-pushed
the
message_notification
branch
from
November 28, 2023 02:07
582e8ee
to
37351a9
Compare
bxy4543
force-pushed
the
message_notification
branch
from
November 28, 2023 09:28
e9bd81d
to
d29f0f6
Compare
bxy4543
force-pushed
the
message_notification
branch
from
November 29, 2023 06:00
d29f0f6
to
fea5e16
Compare
lingdie
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two serious change:
add get user func for db interface
controllers/pkg/database/interface.go
optimize notification struct
controllers/pkg/notification/api/v1/notification_types.go