Compiler cleanup #115
Open
Compiler cleanup #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dihm
added
documentation
to have default arguments compatible with running locally from a script. Also updates docstrings to be a little more details as to function and arguments.
dihm
force-pushed
the
compiler_cleanup
branch
from
f37da3a
to
6083f02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114
This PR removes the deprecated synchronous compilation functions. It also adds default arguments to
labscript_compile_asyncandcompile_multishot_asyncso that they can run in a script using default arguments. Finally, I brushed up a few docstrings to clarify usage a bit.