feat: improve casbin mw #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 63.77% 64.08% +0.31%
==========================================
Files 9 9
Lines 944 944
==========================================
+ Hits 602 605 +3
+ Misses 302 300 -2
+ Partials 40 39 -1 ☔ View full report in Codecov by Sentry. |
aldas
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
LGTM
for anyone passing by - echo casbin docs can be found also here https://echo.labstack.com/docs/middleware/casbin-auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a README.md and improves the coverage test for Casbin middleware.
Description
We changed all hardcoded status codes by the standard's lib constants and echo's HTTP method constants and added a custom skipper test case to improve the package's coverage test.