fix: ipv6 addresses parsing

ladjs · May 13, 2024 · ec50f5a · ec50f5a
1 parent 3317168
commit ec50f5a
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/src/node/index.js b/src/node/index.js
@@ -749,7 +749,7 @@ Request.prototype.request = function () {
   options.method = this.method;
   options.port = url.port;
   options.path = path;
-  options.host = url.hostname;
+  options.host = utils.normalizeHostname(url.hostname); // ex: [::1] -> ::1
   options.ca = this._ca;
   options.key = this._key;
   options.pfx = this._pfx;

diff --git a/src/utils.js b/src/utils.js
@@ -71,6 +71,11 @@ exports.cleanHeader = (header, changesOrigin) => {
   return header;
 };
 
+exports.normalizeHostname = (hostname) => {
+  const [,normalized] = hostname.match(/^\[([^\]]+)\]$/) || [];
+  return normalized || hostname;
+};
+
 /**
  * Check if `obj` is an object.
  *

diff --git a/test/node/basic.js b/test/node/basic.js
@@ -134,6 +134,15 @@ describe('[node] request', () => {
     });
   });
 
+  describe('ipv6 address', () => {
+    it('should successfully query an ipv6 address', (done) => {
+      request.get(`http://[::]/url?a=(b%29`).end((error, res) => {
+        assert.equal('/url?a=(b%29', res.text);
+        done();
+      });
+    });
+  });
+
   describe('.buffer()', () => {
     it('should enable buffering', (done) => {
       request