Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test failure due to localhost being also ipv6 #845

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ikonst
Copy link

@ikonst ikonst commented Oct 28, 2024

On my MacOS machine:

% host localhost.   
localhost has address 127.0.0.1
localhost has IPv6 address ::1

This caused the "should handle connection error" test to fail, since the error was an AggregateError containing both the 127.0.0.1 and the ::1 failure.

To make this uniform across different test environments, I'm changing the hostname to an IPv4 IP address. (It might be worthwhile to test AggregateError behavior and IPv6 behavior but this is not the goal of this PR.)

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@ikonst ikonst changed the title tests: fix test failure due to localhost being also ipv6 test: fix test failure due to localhost being also ipv6 Oct 28, 2024
Depending on runtime environment, "localhost" might resolve to both IPv4 and IPv6, resulting in an AggregateError in place of an Error.
@ikonst
Copy link
Author

ikonst commented Oct 28, 2024

👋 @titanism

@ikonst
Copy link
Author

ikonst commented Nov 6, 2024

@titanism could you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant