Merge pull request #1534 from s-trinh/fix_warnings_non-virtual-dtor

Fix warnings "has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]"
lagadic · Jan 9, 2025 · 39d7d33 · 39d7d33
2 parents 5614fb1 + 146a70b
commit 39d7d33
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/modules/core/include/visp3/core/vpImageMorphology.h b/modules/core/include/visp3/core/vpImageMorphology.h
@@ -143,6 +143,10 @@ class VISP_EXPORT vpImageMorphology
   public:
     vpPixelOperation() { }
 
+#if (VISP_CXX_STANDARD >= VISP_CXX_STANDARD_11)
+    virtual ~vpPixelOperation() = default;
+#endif
+
     virtual T operator()(const T &, const T &) = 0;
   };
 

diff --git a/modules/core/include/visp3/core/vpUKSigmaDrawerAbstract.h b/modules/core/include/visp3/core/vpUKSigmaDrawerAbstract.h
@@ -61,6 +61,8 @@ class VISP_EXPORT vpUKSigmaDrawerAbstract
 
   inline vpUKSigmaDrawerAbstract(const unsigned int &n) : m_n(n) { }
 
+  virtual ~vpUKSigmaDrawerAbstract() = default;
+
   /**
    * \brief Draw the sigma points according to the current mean and covariance of the state
    * of the Unscented Kalman filter.