Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of boolean mask #1311

Merged
merged 11 commits into from
Jan 24, 2024
Merged

Use of boolean mask #1311

merged 11 commits into from
Jan 24, 2024

Conversation

rolalaro
Copy link

  • Possible to use a boolean mask along with vpImageFilter methods to compute desired points only
  • Possible to use a boolean mask along with vpHistogram
  • Possible to use a boolean mask along with vpCannyEdgeDetector
  • Possible to use a boolean mask along with vpCircleHoughTransform

…ns, image histogram, canny filtering and circle Hough detection
@rolalaro rolalaro changed the title Use of boolean mask [DRAFT] Use of boolean mask Jan 17, 2024
@rolalaro rolalaro marked this pull request as draft January 17, 2024 11:44
@rolalaro rolalaro changed the title [DRAFT] Use of boolean mask Use of boolean mask Jan 17, 2024
@rolalaro rolalaro marked this pull request as ready for review January 17, 2024 16:26
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 408 lines in your changes are missing coverage. Please review.

Comparison is base (ebfa260) 53.60% compared to head (3da777d) 53.48%.
Report is 2 commits behind head on master.

❗ Current head 3da777d differs from pull request most recent head ed5d19a. Consider uploading reports for the commit ed5d19a to get more accurate results

Files Patch % Lines
modules/imgproc/src/vpCircleHoughTransform.cpp 0.00% 187 Missing ⚠️
modules/core/include/visp3/core/vpImageFilter.h 67.76% 78 Missing ⚠️
...roc/include/visp3/imgproc/vpCircleHoughTransform.h 0.00% 42 Missing ⚠️
modules/core/src/image/vpImageCircle.cpp 0.00% 37 Missing ⚠️
modules/core/src/tools/histogram/vpHistogram.cpp 74.46% 36 Missing ⚠️
modules/core/src/image/vpImageFilter.cpp 76.59% 11 Missing ⚠️
modules/core/src/image/vpCannyEdgeDetection.cpp 0.00% 10 Missing ⚠️
modules/core/include/visp3/core/vpHistogram.h 33.33% 6 Missing ⚠️
...les/core/include/visp3/core/vpCannyEdgeDetection.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1311      +/-   ##
==========================================
- Coverage   53.60%   53.48%   -0.13%     
==========================================
  Files         399      399              
  Lines       50509    50789     +280     
==========================================
+ Hits        27076    27165      +89     
- Misses      23433    23624     +191     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rolalaro rolalaro marked this pull request as draft January 19, 2024 08:55
@rolalaro rolalaro marked this pull request as ready for review January 19, 2024 10:01
@fspindle fspindle merged commit 1b34914 into lagadic:master Jan 24, 2024
48 of 49 checks passed
@rolalaro rolalaro deleted the feat_cht_masks branch February 12, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants