This repository has been archived by the owner on Apr 30, 2019. It is now read-only.
Minor docs change #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignasi35
approved these changes
Sep 17, 2018
| @@ -37,3 +37,4 @@ See [`CONTRIBUTING.md`](CONTRIBUTING.md). | |||
| * How do I handle `multipart/form-data` file uploads? ([Scala example](./file-upload/file-upload-scala-sbt/README.md)) | |||
| * How do I use a custom message serializer and response header to implement file downloads? ([Scala example](./file-download/file-download-scala-sbt/README.md)) | |||
| * How do I integrate Lightbend Telemetry (Cinnamon)? ([Java/Maven example](./lightbend-telemetry/lightbend-telemetry-java-mvn/README.md)) | |||
| * How do I configure the Circuit Breaker Panel for a Lagom Java application? ([Java/Maven example](./circuitbreakerpanel/circuitbreakerpanel-java-mvn/README.md)) | |||
There was a problem hiding this comment.
Ah! Good addition!
(I always forget about the main index)
There was a problem hiding this comment.
About that, last week I merged https://github.com/lagom/lagom-recipes/tree/master/lightbend-telemetry/log-correlation-java-mvn and forgot to add it to the main README index too. If you could improve this PR with that info it'd be ❤️ .
There was a problem hiding this comment.
How do I use MDC-Log correlation IDs with Lightbend Telemetry (Cinnamon) in Lagom? ([Java/Maven example](./lightbend-telemetry/log-correlation-java-mvn/README.md))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged PR #29. but it needed some minor improvements. I didn't want to start one more review cycle, that PR was already waiting for too long, so I'm sending the fixes on this new PR.