Nuke em all #10
Nuke em all #10
Conversation
|
Zoom support has been changed in that it is more flexible and only checks for the string |
main.py
Outdated
| print(running) | ||
| if running: | ||
| dropLinks[key].append(link) | ||
| await msgCh("<:pingo:822111531063836712> <@&"+str(link[0])+"> "+link[2]+" is online now !1!!\nBreak is Over! Stop playing games! Stop watching youtube!\n<"+link[1]+">",int(key)) | ||
| await msgCh("<:blushylakshy:814288474010025994>",int(key)) | ||
| await msgCh(f"<:pingo:822111531063836712> <@&{link[0]}>, {link[2]} is now online at <{link[1]}>",int(key)) |
There was a problem hiding this comment.
can you change all the user feedback so that the bot's messages are not different?
There was a problem hiding this comment.
I left you a pingo man
There was a problem hiding this comment.
In any case, as a bot cannot use emoji from servers it is not part in, this significantly reduces portability if custom emoji are used, which is not quite in line with claims on the README or negatively impacts those who wish to run the software themselves.
There was a problem hiding this comment.
Would dropping all emoji but retaining older messages do?
There was a problem hiding this comment.
this significantly reduces portability
I don't care keep the emojis and don't change the messages >:(
There was a problem hiding this comment.
Unfortunately, this is one area I am not willing to budge in. The pingos must die.
Co-authored-by: NoYouNotUrUncle <[email protected]>
| @@ -74,7 +82,7 @@ async def startDriver(): #start a new driver and log in to gapps | |||
| driver = webdriver.Chrome(options=browser_options) | |||
| driver.set_page_load_timeout(10) #restart driver after 5s of monkeying (cus google block prolly!) | |||
| #go to google.yrdsb.ca and log in | |||
| driver.get("https://google.yrdsb.ca/EasyConnect/SSO/Redirect.aspx?SAMLRequest=fVLLTuswEN0j8Q%2BR93myqawmqBeEbiUeEQ0s7s51pqlvbE%2FwOC38PW5KBSxge3zmPMYzv3w1OtqBI4W2ZHmSsQisxFbZrmRPzU08Y5fV%2BdmchNEDX4x%2Bax%2FhZQTyUZi0xKeHko3OchSkiFthgLiXfLW4u%2BVFkvHBoUeJmkXL65Jtdata0KIfuu1GGAM9ygGtlbJfYw92bdD0%2F9vAfj7FKg6xlkQjLC15YX2AsiKPs4s4nzVZxosLXsz%2Bsaj%2BcPqj7LHBb7HWRxLxv01Tx%2FXDqpkEdiGduw%2FsknWInYZEojnY14JI7QK8EZqARQsicD4EvEJLowG3ArdTEp4eb0NL7wfiabrf75NPmVSknRgGSt5cS%2BtEilRIYtW0XT4VdF%2FW%2Bnt8cbJn1afBPP0iVX382qHM8rpGreRbtNAa91cOhA9NvBtDkRt0Rvif3fIknxDVxpuJykdLA0i1UdCyKK2Ort%2FPIxzNOw%3D%3D&RelayState=https%3A%2F%2Fwww.google.com%2Fa%2Fgapps.yrdsb.ca%2FServiceLogin%3Fservice%3Dwise%26passive%3Dtrue%26continue%3Dhttps%253A%252F%252Fdrive.google.com%252Fa%252Fgapps.yrdsb.ca%252F%26followup%3Dhttps%253A%252F%252Fdrive.google.com%252Fa%252Fgapps.yrdsb.ca%252F%26faa%3D1") | |||
| driver.get("https://google.yrdsb.ca") | |||
There was a problem hiding this comment.
This doesn't work don't change this line.
| driver.get("https://google.yrdsb.ca") | |
| driver.get("https://google.yrdsb.ca/EasyConnect/SSO/Redirect.aspx?SAMLRequest=fVLLTuswEN0j8Q%2BR93myqawmqBeEbiUeEQ0s7s51pqlvbE%2FwOC38PW5KBSxge3zmPMYzv3w1OtqBI4W2ZHmSsQisxFbZrmRPzU08Y5fV%2BdmchNEDX4x%2Bax%2FhZQTyUZi0xKeHko3OchSkiFthgLiXfLW4u%2BVFkvHBoUeJmkXL65Jtdata0KIfuu1GGAM9ygGtlbJfYw92bdD0%2F9vAfj7FKg6xlkQjLC15YX2AsiKPs4s4nzVZxosLXsz%2Bsaj%2BcPqj7LHBb7HWRxLxv01Tx%2FXDqpkEdiGduw%2FsknWInYZEojnY14JI7QK8EZqARQsicD4EvEJLowG3ArdTEp4eb0NL7wfiabrf75NPmVSknRgGSt5cS%2BtEilRIYtW0XT4VdF%2FW%2Bnt8cbJn1afBPP0iVX382qHM8rpGreRbtNAa91cOhA9NvBtDkRt0Rvif3fIknxDVxpuJykdLA0i1UdCyKK2Ort%2FPIxzNOw%3D%3D&RelayState=https%3A%2F%2Fwww.google.com%2Fa%2Fgapps.yrdsb.ca%2FServiceLogin%3Fservice%3Dwise%26passive%3Dtrue%26continue%3Dhttps%253A%252F%252Fdrive.google.com%252Fa%252Fgapps.yrdsb.ca%252F%26followup%3Dhttps%253A%252F%252Fdrive.google.com%252Fa%252Fgapps.yrdsb.ca%252F%26faa%3D1") |
There was a problem hiding this comment.
Have you tested it? I've run many trials on my end and I've not had a single issue with either this or the initial proposed change.
There was a problem hiding this comment.
To be clear, have you tested it in isolation? It should be fairly easy to test this yourself and if you can determine that something breaks I'll revert it.
Co-authored-by: NoYouNotUrUncle <[email protected]>
Co-authored-by: NoYouNotUrUncle <[email protected]>
Co-authored-by: NoYouNotUrUncle <[email protected]>
|
When requesting changes, please make every change you would like to see before requesting them. |
This PR effectively adds #8, #7, #4, and #1 and merges them all. Instead of
os.startfile, it relies onsys.exit(1)to kill itself and use an external service manager such as systemd to restart the script.