Use mksquashfs pseudofile definitions for AppImage build #228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way that appimage squashfs files are built with rules_appimage. Instead of taring up all the files and then providing that to mksquashfs we build a pseudo file definitions list that tells mksquashfs where to get all the files from. This avoids the expensive tar operation when inputs change (building the pseudofile defs is pretty cheap).
The mksquashfs action does take longer now (likely because it has to do thousands of
sh -c "cat {file}"
invocations) but overall the build times are lower for large appimages and the cachability remote execution ability should be better.There was also an issue with the most recent MkAppDir implementation where the tar was populated in a ThreadPool which was not deterministic, so file order inside the .tar and .sqfs may change, leading to changed artifact hashes. This is resolved with this.