Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mksquashfs pseudofile definitions for AppImage build #228

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

lalten
Copy link
Owner

@lalten lalten commented Sep 24, 2024

This changes the way that appimage squashfs files are built with rules_appimage. Instead of taring up all the files and then providing that to mksquashfs we build a pseudo file definitions list that tells mksquashfs where to get all the files from. This avoids the expensive tar operation when inputs change (building the pseudofile defs is pretty cheap).
The mksquashfs action does take longer now (likely because it has to do thousands of sh -c "cat {file}" invocations) but overall the build times are lower for large appimages and the cachability remote execution ability should be better.

There was also an issue with the most recent MkAppDir implementation where the tar was populated in a ThreadPool which was not deterministic, so file order inside the .tar and .sqfs may change, leading to changed artifact hashes. This is resolved with this.

@lalten lalten marked this pull request as ready for review September 27, 2024 10:24
@lalten lalten merged commit 5c2db08 into main Sep 27, 2024
9 checks passed
@lalten lalten deleted the pseudo-file-defs branch September 27, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant