Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Default for PreEscaped #371

Merged
merged 3 commits into from
Apr 16, 2023
Merged

Conversation

imbolc
Copy link
Contributor

@imbolc imbolc commented Mar 24, 2023

Tests was broken before the change, I'm not sure if I should fix them. But cargo test misc works.

@imbolc
Copy link
Contributor Author

imbolc commented Mar 24, 2023

Also I noticed seemingly unnecessary type restriction:
struct PreEscaped<T: AsRef<str>>(pub T). I believe removing the AsRef restriction won't change any behavior, but it won't be necessary to repeat the restriction in each implementation. I can remove it in this PR if you'd like.

maud/tests/misc.rs Outdated Show resolved Hide resolved
@lambda-fairy
Copy link
Owner

Thanks!

I believe removing the AsRef restriction won't change any behavior, but it won't be necessary to repeat the restriction in each implementation. I can remove it in this PR if you'd like.

That sounds like a good change. Though I'd prefer that in a separate PR, just to keep things small.

That reminds me, I should polish up #322 again...

@lambda-fairy lambda-fairy enabled auto-merge (squash) April 16, 2023 05:27
@lambda-fairy lambda-fairy merged commit 34b3bc0 into lambda-fairy:main Apr 16, 2023
@imbolc imbolc deleted the impl-default branch April 16, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants