Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests for prepare_os_context #114

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

mmsc2
Copy link
Contributor

@mmsc2 mmsc2 commented Nov 9, 2022

No description provided.

@mmsc2 mmsc2 changed the title [WIP] Integration tests for prepare_os_context Integration tests for prepare_os_context Nov 10, 2022
Copy link
Member

@Oppen Oppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except from the questions below.
On another note, we should start thinking about adding a proper test framework for Python I believe. Probably PyTest.

python3 hints_tests.py && \
python3 get_builtins_initial_stack.py && \
./run_python_tests.sh && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the PYENV_VERSION still the same here? I'm not entirely sure if the venv takes care of that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as i know yes, venv takes care about the python version with which the tests are ran.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure?

Comment on lines +2 to +7
echo "Running hint tests"
python3 tests/hints_tests.py
python3 tests/get_builtins_initial_stack.py

echo "Running prepare_os_context integration tests"
python3 tests/prepare_os_context.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants