Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test reproducing bug #808 #810

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Add test reproducing bug #808 #810

merged 5 commits into from
Sep 30, 2024

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Sep 26, 2024

A test to reproduce #808

Copy link

github-actions bot commented Sep 26, 2024

Benchmark results Main vs HEAD

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.232 ± 0.053 3.130 3.302 1.01 ± 0.02
base factorial_2M.cairo (JIT) 3.221 ± 0.068 3.113 3.340 1.01 ± 0.02
head factorial_2M.cairo (AOT) 3.190 ± 0.036 3.141 3.254 1.00 ± 0.01
base factorial_2M.cairo (AOT) 3.185 ± 0.014 3.153 3.205 1.00
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.723 ± 0.042 2.653 2.792 1.01 ± 0.02
base fib_2M.cairo (JIT) 2.738 ± 0.026 2.685 2.776 1.01 ± 0.01
head fib_2M.cairo (AOT) 2.719 ± 0.045 2.637 2.784 1.01 ± 0.02
base fib_2M.cairo (AOT) 2.701 ± 0.026 2.652 2.745 1.00
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.087 ± 0.028 3.037 3.132 1.04 ± 0.01
base logistic_map.cairo (JIT) 3.107 ± 0.031 3.063 3.170 1.04 ± 0.01
head logistic_map.cairo (AOT) 2.980 ± 0.028 2.944 3.050 1.00
base logistic_map.cairo (AOT) 3.091 ± 0.042 3.047 3.170 1.04 ± 0.02

@edg-l edg-l closed this Sep 27, 2024
@edg-l edg-l reopened this Sep 27, 2024
@edg-l edg-l changed the base branch from main to fix-snapshot-clones September 27, 2024 09:38
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (7aeaa8c) to head (e55de92).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
+ Coverage   87.88%   88.03%   +0.15%     
==========================================
  Files         122      122              
  Lines       34270    34270              
==========================================
+ Hits        30117    30171      +54     
+ Misses       4153     4099      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edg-l edg-l changed the title Add failing test reproducing bug #808 Add test reproducing bug #808 Sep 27, 2024
azteca1998
azteca1998 previously approved these changes Sep 27, 2024
Base automatically changed from fix-snapshot-clones to main September 27, 2024 16:02
@azteca1998 azteca1998 dismissed their stale review September 27, 2024 16:02

The base branch was changed.

@pefontana pefontana added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit ae17dd3 Sep 30, 2024
15 checks passed
@pefontana pefontana deleted the bug_808 branch September 30, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants