Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add L2 to L1 logs to the pubdata #41

Closed
ilitteri opened this issue Jan 16, 2024 · 1 comment · Fixed by #42
Closed

Do not add L2 to L1 logs to the pubdata #41

ilitteri opened this issue Jan 16, 2024 · 1 comment · Fixed by #42

Comments

@ilitteri
Copy link
Collaborator

L2 to L1 logs are being added to the pubdata construction for both Rollup and Validium modes.

On Validium mode the pubdata should be empty, so we need to avoid adding the L2 to L1 logs to it.

Lines: https://github.com/lambdaclass/zksync-era/blob/validium_mode_pubdata_0_env/core/lib/types/src/commitment.rs#L227-L231

@ilitteri ilitteri added this to the Validium Mode: Make it work milestone Jan 16, 2024
@ilitteri ilitteri linked a pull request Jan 16, 2024 that will close this issue
5 tasks
@ilitteri
Copy link
Collaborator Author

Resolved in #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant