feat: Remove logs from pubdata #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilitteri
requested changes
Jan 16, 2024
toni-calvin
changed the base branch from
validium_mode
to
validium_mode_pubdata_0_env
|
Here are the results executing the validium example with this changes: |
ilitteri
approved these changes
Jan 16, 2024
ilitteri
pushed a commit
that referenced
this pull request
Jan 19, 2024
* set pubdata constants to 0 * Set to 0 * Create contract for writing bytes * Deploy bytes contract * update full node to use rpc providers * fmt * add colored prints * add better debug logs * add better logs * add erc20 contract and update test * update logs * print gas used * Use `ETH_SENDER_SENDER_VALIDIUM_MODE` to check whether we need to charge the pubdata * wip * wip 2: just change runtime behavior * Restore original values * Add validium example readme (#34) * Add validium example readme * update validium.md and change test name * fmt --------- Co-authored-by: toni-calvin <[email protected]> * Only keep changes for vm_latest * Fix submodule * Fix integration test license * change contracts branch * Remove l1 gas data * Update submodule branch * fix: update output readme (#39) * Update output readme * Add a note for transactions * Fix note * feat: remove logs pubdata (#42) * remove logs from pubdata * update comment * feat: refactor readme example (#44) * Refactor readme example * Fix some comments * Remove validium.md * Remove debug prints * Remove debug files * zk fmt --------- Co-authored-by: toni-calvin <[email protected]> Co-authored-by: Ivan Litteri <[email protected]> Co-authored-by: Jordi <[email protected]> Co-authored-by: Jordi <[email protected]> Co-authored-by: Matías Onorato <[email protected]> Co-authored-by: Antonio Calvín García <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
closes #41
Why ❔
Checklist
zk fmtandzk lint.zk spellcheck.