Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deposit tests #117

Closed
wants to merge 4 commits into from
Closed

Fix deposit tests #117

wants to merge 4 commits into from

Conversation

juan518munoz
Copy link

@juan518munoz juan518munoz commented Feb 8, 2024 •
edited by fkrause98
Loading

What ❔

Closes #126

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

Oppen pushed a commit that referenced this pull request Feb 9, 2024
@benceharomi
Revert "sync with main (#116)" (#117)
06ac6b4
@fkrause98 fkrause98 linked an issue Feb 9, 2024 that may be closed by this pull request
Improve deposit tests #126
Open
@juan518munoz juan518munoz deleted the deposit-test-fix branch April 19, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mationorato mationorato Awaiting requested review from mationorato mationorato will be requested when the pull request is marked ready for review mationorato is a code owner

@jrchatruc jrchatruc Awaiting requested review from jrchatruc jrchatruc will be requested when the pull request is marked ready for review jrchatruc is a code owner

@ilitteri ilitteri Awaiting requested review from ilitteri ilitteri will be requested when the pull request is marked ready for review ilitteri is a code owner

@juanbono juanbono Awaiting requested review from juanbono juanbono will be requested when the pull request is marked ready for review juanbono is a code owner

@IAvecilla IAvecilla Awaiting requested review from IAvecilla IAvecilla will be requested when the pull request is marked ready for review IAvecilla is a code owner

Assignees
No one assigned
Labels
erc20-base-token
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve deposit tests
2 participants
@juan518munoz @fkrause98