Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: protobuf and lint fixes #125

Merged
merged 4 commits into from
Feb 14, 2024
Merged

fix: protobuf and lint fixes #125

merged 4 commits into from
Feb 14, 2024

Conversation

Oppen
Copy link
Member

@Oppen Oppen commented Feb 9, 2024

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

ilitteri
ilitteri approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@ilitteri ilitteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oppen Oppen changed the title Feat validium pubdata abstraction ci fixes fix: protobuf and lint fixes Feb 9, 2024
@ilitteri ilitteri merged commit 502f3e8 into feat_validium_pubdata_abstraction Feb 14, 2024
16 of 21 checks passed
@ilitteri ilitteri deleted the feat_validium_pubdata_abstraction_ci_fixes branch February 14, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilitteri ilitteri ilitteri approved these changes

Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oppen @ilitteri