forked from matter-labs/zksync-era
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Abstract GasAdjuster for Rollup and Validium #127
Closed
jordibonet-lambdaclass
wants to merge
38
commits into
validium_mode_new_fee_model_final
from
abstract-gas-adjuster
Closed
feat: Abstract GasAdjuster for Rollup and Validium #127
jordibonet-lambdaclass
wants to merge
38
commits into
validium_mode_new_fee_model_final
from
abstract-gas-adjuster
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Needs to fix errors in tests related to the new Generic Data Type
…ods from L1BatchWithMetadata as they're now part of the L1BatchCommitter trait and utils in the case of construct_pubdata
…mmitOperation construction and DatasizeCriterion::last_l1_batch_to_publish usage
…_publish parameter (only used by DataSizeCriterion)
…tter::l1_commit_data function
…l1_commit_data function
…ter depending on the VALIDIUM_MODE env value
…class/zksync-era into feat_validium_pubdata_abstraction
* Rename Validium pubdata abstraction and implementors * Rename struct fields and variables * feat: Abstract commit data generator initialization (#94) * Add L1BatchCommitDataGeneratorMode to StateKeeperConfig * Initialize L1BatchCommitter depending on the StateKeeperConfig * Fix bad merge
…lidium_pubdata_abstraction
…class/zksync-era into feat_validium_pubdata_abstraction
…class/zksync-era into feat_validium_pubdata_abstraction
toni-calvin
force-pushed
the
abstract-gas-adjuster
branch
from
February 14, 2024 15:02
6ec7665
to
6692ea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zk fmt
andzk lint
.zk spellcheck
.zk linkcheck
.