Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adapt zksync_env_config::eth_sender tests for running both in Validium mode and Rollup mode #142

Merged
merged 2 commits into from
Feb 16, 2024
Merged

feat: adapt zksync_env_config::eth_sender tests for running both in Validium mode and Rollup mode #142

merged 2 commits into from
Feb 16, 2024

Conversation

toni-calvin
Copy link

@toni-calvin toni-calvin commented Feb 16, 2024 •
edited
Loading

Closes #134

Changes Made

This pull request introduces enhancements to the existing test suite for the ETHSenderConfig in the env_config crate. The primary goal is to create dedicated configurations for Rollup and Validium scenarios and provide specific tests for each.

Key Modifications

New Test Configurations:

  • Two new functions, rollup_expected_config and validium_expected_config, have been added to generate configurations tailored for Rollup and Validium use cases.
  • Additional Test Methods: Two new test methods, rollup_from_env and validium_from_env, have been implemented to specifically test Rollup and Validium configurations, respectively.
  • Validium Configuration Adjustment: The validium_expected_config function now sets the l1_gas_per_pubdata_byte field to 0 for Validium, reflecting the required Validium configuration.

How to test

zk test rust --package zksync_env_config --lib -j 1 -- eth_sender::tests

@toni-calvin toni-calvin changed the title add validium env test feat: adapt env_eth_sender tests for running both in Validium mode and Rollup mode #120 Feb 16, 2024
@toni-calvin toni-calvin changed the title feat: adapt env_eth_sender tests for running both in Validium mode and Rollup mode #120 feat: adapt zksync_env_config::eth_sender tests for running both in Validium mode and Rollup mode #120 Feb 16, 2024
@toni-calvin toni-calvin changed the title feat: adapt zksync_env_config::eth_sender tests for running both in Validium mode and Rollup mode #120 feat: adapt zksync_env_config::eth_sender tests for running both in Validium mode and Rollup mode Feb 16, 2024
@toni-calvin toni-calvin linked an issue Feb 16, 2024 that may be closed by this pull request
Adapt tests for testing both with Rollup and Validium mode in zksync_env_config::eth_sender module #134
Closed
@ilitteri ilitteri self-requested a review February 16, 2024 15:51
ilitteri
ilitteri approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@ilitteri ilitteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests are passing on my side. For the next time remember to show how to run the tests in the PRs description

@ilitteri ilitteri merged commit 08fa235 into feat_validium_pubdata_abstraction Feb 16, 2024
7 of 11 checks passed
@ilitteri ilitteri deleted the adapt-env-eth_sender-tests-validium branch February 16, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilitteri ilitteri ilitteri approved these changes

Assignees

@toni-calvin toni-calvin

Labels
external-contribution validium
Projects
None yet
Milestone
Validium Mode: Make it work
Development

Successfully merging this pull request may close these issues.

Adapt tests for testing both with Rollup and Validium mode in zksync_env_config::eth_sender module
2 participants
@toni-calvin @ilitteri