Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM Simulator code hash in witness data #249

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

IAvecilla
Copy link
Collaborator

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

Copy link

github-actions bot commented Aug 28, 2024

Hey there! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Examples of valid PR titles:

  • feat(eth_sender): Support new transaction type
  • fix(state_keeper): Correctly handle edge case
  • ci: Add new workflow for linting

Details:

No release type found in pull request title "EVM Simulator code hash in witness data". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

.factory_deps_dal()
.get_sealed_factory_dep(evm_simulator)
.await?
.ok_or_else(|| anyhow!("Default account bytecode should exist"))?;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.ok_or_else(|| anyhow!("Default account bytecode should exist"))?;
.ok_or_else(|| anyhow!("EVM simulator bytecode should exist"))?;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But generally, do we actually want to force it here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least in this PR, it should be enforced just to check if everything on the prover side works okay. We have this other PR that makes the EVM simulator optional with a custom new flag, so maybe we can change this logic there to also make it optional here.

@0xVolosnikov
Copy link

And now we also need to actually use it here:

// NOTE: this will be evm_simulator_code_hash in future releases
input.vm_run_data.default_account_code_hash,

@jrchatruc jrchatruc merged commit f927c26 into evm-equivalence-yul-new Aug 30, 2024
8 of 50 checks passed
@jrchatruc jrchatruc deleted the evm-simulator-witness-data branch August 30, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants