Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eigen Blob ID in L1 #269

Closed
wants to merge 4 commits into from
Closed

Conversation

gianbelinche
Copy link

What ❔

This PR adds the blob id to be stored on L1 when a batch is committed
It also adds a script for retrieving them directly from L1.
To run it:

cd get_all_blobs
node getallblobs.js

This PR changes the contracts submodule to point to the eigen-blobid-l1 branch

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

Copy link

github-actions bot commented Sep 17, 2024

Hey there! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Examples of valid PR titles:

  • feat(eth_sender): Support new transaction type
  • fix(state_keeper): Correctly handle edge case
  • ci: Add new workflow for linting

Details:

No release type found in pull request title "Eigen Blob ID in L1". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@gianbelinche gianbelinche marked this pull request as ready for review September 18, 2024 13:22
@gianbelinche gianbelinche changed the base branch from eigen-implementation to da-eigen-implementation September 18, 2024 13:27
@gianbelinche gianbelinche changed the base branch from da-eigen-implementation to eigen-implementation September 18, 2024 13:57

async function getTransactions() {
const latestBlock = await web3.eth.getBlockNumber();
const validatorTimelockAddress = "0xeacf0411de906bdd8f2576692486383797d06004";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this address should not be hardcoded. Can you parameterize it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants