feat: concurrent da_dispatcher #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanbono
reviewed
Oct 2, 2024
juanbono
reviewed
Oct 2, 2024
juanbono
reviewed
Oct 2, 2024
| async fn dispatch_batches(&self, stop_receiver: Receiver<bool>) -> anyhow::Result<()> { | ||
| let (tx, mut rx) = mpsc::channel(100); | ||
|
|
||
| let next_expected_batch = Arc::new(AtomicI64::new(NO_FIRST_BATCH)); |
There was a problem hiding this comment.
can you add some docs here about why this atomic is needed?
There was a problem hiding this comment.
I've replaced the AtomicI64 in favour of a Mutex that holds an Option, which makes the code clearer. I can add some docs if you still consider it necessary.
juanbono
reviewed
Oct 2, 2024
juanbono
reviewed
Oct 2, 2024
juanbono
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zk fmtandzk lint.