feat: set native token env var #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan518munoz
requested review from
mationorato,
jrchatruc,
ilitteri,
juanbono and
IAvecilla
as code owners
IAvecilla
reviewed
Jan 20, 2024
Comment on lines
+51
to
54
| const nativeErc20Testing = process.env.CONTRACTS_L1_NATIVE_ERC20_TOKEN_ADDR ? true : false; // if set, we assume user wants to test native erc20 tokens | ||
|
|
||
| let mainWalletPK; | ||
| if (nativeErc20Testing) { |
There was a problem hiding this comment.
I know is not exactly part of this PR but you could do if (process.env.CONTRACTS_L1_NATIVE_ERC20_TOKEN_ADDR) and it should work fine.
There was a problem hiding this comment.
Yes it would, but I though that it would be better to declare a shorter variable once, and then use it three times, than calling calling process.env.CONTRACTS_L1_NATIVE_ERC20_TOKEN_ADDR each time.
IAvecilla
reviewed
Jan 20, 2024
Comment on lines
635
to
643
| try { | ||
| return JSON.parse( | ||
| fs.readFileSync(configPath, { | ||
| encoding: 'utf-8' | ||
| }) | ||
| ); | ||
| } catch (e) { | ||
| throw e; | ||
| } |
There was a problem hiding this comment.
Let me know if I'm overlooking smth, but if you plan to leave the error as is and simply propagate it, you can remove the try/catch block and keep only the parsing function, right?
There was a problem hiding this comment.
Correct, I'm still confused about some aspects of the language.
SantiagoPittella
approved these changes
Jan 22, 2024
Oppen
pushed a commit
that referenced
this pull request
Feb 9, 2024
* use compatible error codes with the previous version * update hashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Set a native token environment variable:
CONTRACTS_L1_NATIVE_ERC20_TOKEN_ADDRon native token deployment.Note: with the current implementation, if the previously mentioned env var is set, testing will be done with native token variables.
Why ❔
Prevent user from having to set token related environment variables manually, which is error prone.
Checklist
zk fmtandzk lint.