Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest PHP 8.1 syntax #129

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

samsonasik
Copy link
Member

Q A
QA yes

Description

Since composer.json require php 8.1, php 8.1 syntax can be applied.

@samsonasik
Copy link
Member Author

samsonasik commented Nov 2, 2024

Ready to review 👍 , CI error on php 8.2 and 8.3 seems unrelated.

https://github.com/laminas/laminas-cli/actions/runs/11642048570/job/32421206364?pr=129#step:3:406

as happen on other PR as well, like in #126

@samsonasik samsonasik added this to the 1.11.0 milestone Nov 2, 2024
@fezfez
Copy link
Contributor

fezfez commented Nov 17, 2024

@samsonasik see #131 to fix CI

@samsonasik
Copy link
Member Author

I will rebase when I back to pc

@samsonasik samsonasik self-assigned this Nov 21, 2024
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@samsonasik samsonasik force-pushed the update-to-latest-php81-syntax branch from 5496332 to a7c8eff Compare November 22, 2024 02:14
@samsonasik
Copy link
Member Author

Rebased 👍

@samsonasik samsonasik requested a review from gsteel November 22, 2024 02:15
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samsonasik 👍

@gsteel gsteel merged commit 159b48f into laminas:1.11.x Nov 22, 2024
13 checks passed
@samsonasik samsonasik deleted the update-to-latest-php81-syntax branch November 22, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants