Add PHPStan support #315
Open
Add PHPStan support #315
+275
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
settermjd
added
Enhancement
QA
After some discussion with @tyrsson, we decided to use PHPStan instead of Psalm for static analysis on the project. This change both adds support for it and adds a small Composer script to simplify using it. Signed-off-by: Matthew Setter <[email protected]>
This change makes it easier to add extensions to PHPStan in the future, such as the deprecated code extension that checks for deprecated code. Signed-off-by: Matthew Setter <[email protected]>
This is a small code clean up after adding PHPStan support. There are a number of other recommendations from PHPStan, but at this stage, the test suite needs to be fixed before they can be attended to. But, this small list is workable. Signed-off-by: Matthew Setter <[email protected]>
settermjd
force-pushed
the
add-phpstan-support
branch
from
366ffa2 to
ae806f7
Compare
|
@settermjd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for PHPStan, including adding a Composer script to simplify using it. In addition, it makes a few small fixes, removing/replacing references to deprecated code.