♻️ Move definition of suffixes into lamindb (#815)

* ♻️ Move definition of suffixes into lamindb * ✅ Restore a test for composite suffix
laminlabs · Aug 7, 2024 · b10f700 · b10f700
1 parent defbabf
commit b10f700
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/lamindb_setup/core/upath.py b/lamindb_setup/core/upath.py
@@ -56,11 +56,8 @@
     ".zarr",
     ".json",
 }
-VALID_COMPOSITE_SUFFIXES = {
-    ".anndata.zarr",
-    ".spatialdata.zarr",
-    ".ome.zarr",
-}
+# below gets updated within lamindb because it's frequently changing
+VALID_COMPOSITE_SUFFIXES = {".anndata.zarr"}
 
 TRAILING_SEP = (os.sep, os.altsep) if os.altsep is not None else os.sep
 

diff --git a/tests/storage/test_storage_basis.py b/tests/storage/test_storage_basis.py
@@ -19,7 +19,7 @@ def test_extract_suffix_from_path():
         ("logs/date.log.123", ""),  # digits are no valid suffixes
         ("salmon.merged.gene_counts.tsv", ".tsv"),
         ("salmon.merged.gene_counts.tsv.gz", ".tsv.gz"),
-        ("filename.v1.1.0.spatialdata.zarr", ".spatialdata.zarr"),
+        ("filename.v1.1.0.anndata.zarr", ".anndata.zarr"),
     ]
     for path, suffix in collection:
         filepath = Path(path)