♻️ Save schema to hub upon init #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falexwolf
commented
Jun 24, 2024
| if isettings.dialect != "sqlite": | ||
| from ._schema_metadata import update_schema_in_hub | ||
|
|
||
| update_schema_in_hub() |
There was a problem hiding this comment.
@fredericenard - the instance and everything in the hub are fully generated at this point.
Evidently, this function is called by the user who creates the instance, so the JWT should be correct.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #782 +/- ##
==========================================
+ Coverage 82.15% 82.22% +0.06%
==========================================
Files 41 41
Lines 3115 3116 +1
==========================================
+ Hits 2559 2562 +3
+ Misses 556 554 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.