Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Allow to synchronize via st_size if st_mtime is not present in UPath.stat() #913

Merged
merged 14 commits into from
Dec 17, 2024

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Dec 16, 2024

Needed to allow synchronization for http links.

Copy link

github-actions bot commented Dec 16, 2024

@github-actions github-actions bot temporarily deployed to pull request December 16, 2024 15:34 Inactive
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.75%. Comparing base (5076b1a) to head (07298fd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lamindb_setup/core/upath.py 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #913      +/-   ##
==========================================
+ Coverage   83.69%   83.75%   +0.05%     
==========================================
  Files          43       43              
  Lines        3429     3434       +5     
==========================================
+ Hits         2870     2876       +6     
+ Misses        559      558       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request December 16, 2024 19:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 16, 2024 19:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 16, 2024 19:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 16, 2024 19:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 16, 2024 20:17 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 16, 2024 21:05 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 17, 2024 10:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 17, 2024 11:10 Inactive
@Koncopd Koncopd merged commit db43bf3 into main Dec 17, 2024
13 checks passed
@Koncopd Koncopd deleted the http_sync branch December 17, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant