Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix init instance tests and add init of a local instance in cwd #917

Merged
merged 8 commits into from
Dec 23, 2024

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Dec 23, 2024

Fix laminlabs/lamindb#2180
Also fix incorrect tests in test_init_instance.py

Copy link

github-actions bot commented Dec 23, 2024

@github-actions github-actions bot temporarily deployed to pull request December 23, 2024 14:00 Inactive
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.61%. Comparing base (0a1fddc) to head (5b00089).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lamindb_setup/core/_settings.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
- Coverage   83.79%   83.61%   -0.19%     
==========================================
  Files          43       43              
  Lines        3432     3429       -3     
==========================================
- Hits         2876     2867       -9     
- Misses        556      562       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request December 23, 2024 15:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 23, 2024 16:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 23, 2024 16:24 Inactive
@Koncopd
Copy link
Member Author

Koncopd commented Dec 23, 2024

Test coverage was higher due to an incorrect test setup, can't really restore it fully with the correct setup.

@Koncopd Koncopd changed the title 🐛 Fix init of local instance in cwd 🐛 Fix init of a local instance in cwd Dec 23, 2024
@Koncopd Koncopd changed the title 🐛 Fix init of a local instance in cwd 🐛 Fix test_init an add init of a local instance in cwd Dec 23, 2024
@Koncopd Koncopd changed the title 🐛 Fix test_init an add init of a local instance in cwd 🐛 Fix test_init and add init of a local instance in cwd Dec 23, 2024
@Koncopd Koncopd changed the title 🐛 Fix test_init and add init of a local instance in cwd 🐛 Fix init instance tests and add init of a local instance in cwd Dec 23, 2024
@github-actions github-actions bot temporarily deployed to pull request December 23, 2024 16:40 Inactive
@Koncopd Koncopd merged commit 581271f into main Dec 23, 2024
11 of 13 checks passed
@Koncopd Koncopd deleted the fix_init_cwd branch December 23, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚸 Creating a local instance for the cwd
1 participant