-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🥅 Check instance.modules when loading a lamindb schema module #946
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #946 +/- ##
==========================================
- Coverage 83.91% 83.90% -0.02%
==========================================
Files 43 43
Lines 3469 3491 +22
==========================================
+ Hits 2911 2929 +18
- Misses 558 562 +4 ☔ View full report in Codecov by Sentry. |
This looks interesting, but I don't understand why it's needed. What's the motivation & outcome in plain words? |
lamindb_setup/_check_setup.py
Outdated
_check_in_modules(from_module) | ||
il.reload(il.import_module(from_module)) | ||
else: | ||
infer_module = _module_name() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly?
this gets triggered for example in this case:
import lamindb as ln # connected, django is setup
import wetlab as wl # calls _check_instance_setup() without specifying from_module, module name needs to be inferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
49a151c
to
dd09b24
Compare
@falexwolf are you fine with this now? |
And raise
RuntimeError
if it is not there.