Skip to content

Commit

Permalink
Fix macOS runner (#66)
Browse files Browse the repository at this point in the history
* Install OpenBLAS on macOS in check action

* Install meson=1.5.0 on macOS in check action

* Try using pip without --user

* Fix typo in pip command

* Use hack to get homebrew to install meson v1.5.2

See https://nelson.cloud/how-to-install-older-versions-of-homebrew-packages/
for instructions

* Try getting homebrew to remove meson first

* Remove which calls`

* Stop homebrew removing meson

* Try instlal pkg-config with homebrew

* Try using conda on macOS

* try workaround

* attempt 2

* alternative solution

* export environment variables

* try not installing openblas

* another attempt

* remove pep517

* another attempt

* try with gcc

* fix version

* yet another experiment

* pin version of numpy

* fix ga

* pin to numpy 2.0

* try with python 3.12

* simplify

* switch to macos-latest

* simplify

* try without installing scipy

* simplify

* update changelog

---------

Co-authored-by: Luke Zappia <[email protected]>
  • Loading branch information
rcannood and lazappi authored Oct 29, 2024
1 parent dcacbb6 commit 6a3ed4c
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 5 deletions.
25 changes: 20 additions & 5 deletions .github/workflows/R-CMD-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,12 @@ jobs:
fail-fast: false
matrix:
config:
- { os: macos-latest, r: "release" }
- { os: windows-latest, r: "release" }
- { os: ubuntu-latest, r: "devel", http-user-agent: "release" }
- { os: ubuntu-latest, r: "release" }
- { os: ubuntu-latest, r: "oldrel-1" }
# note: we use python 3.12 on mac os x so we can install scipy 1.13 from a wheel
- { os: macos-latest, r: "release", python: "3.12" }
- { os: windows-latest, r: "release", python: "3.x" }
- { os: ubuntu-latest, r: "devel", http-user-agent: "release", python: "3.x" }
- { os: ubuntu-latest, r: "release", python: "3.x" }
- { os: ubuntu-latest, r: "oldrel-1", python: "3.9" }

env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -38,12 +39,26 @@ jobs:

- uses: r-lib/actions/setup-tinytex@v2

- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.config.python }}

- uses: r-lib/actions/setup-r@v2
with:
r-version: ${{ matrix.config.r }}
http-user-agent: ${{ matrix.config.http-user-agent }}
use-public-rspm: true

# manually installing openblas as a workaround for issue
# https://github.com/laminlabs/laminr/issues/57
- name: Install OpenBLAS
if: runner.os == 'macOS'
run: |
brew install openblas
OPENBLAS=$(brew --prefix openblas)
echo "LDFLAGS=-L$OPENBLAS/lib" >> $GITHUB_ENV
echo "CPPFLAGS=-I$OPENBLAS/include" >> $GITHUB_ENV
- name: Install lamindb
run: |
pip install lamindb[aws]
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ For more information, please visit the [package website](https://laminr.lamin.ai

* Add alternative error message when no message is returned from the API (PR #30).

* Manually install OpenBLAS on macOS (PR #62).

* Switch to Python 3.12 for being able to install scipy on macOS (PR #66).

# laminr v0.0.1

Initial POC implementation of the LaminDB API client for R.
Expand Down

0 comments on commit 6a3ed4c

Please sign in to comment.