Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚸 Improve the user experience for setting up Python & reticulate #129

Merged
merged 26 commits into from
Dec 20, 2024
Merged

🚸 Improve the user experience for setting up Python & reticulate #129

merged 26 commits into from
Dec 20, 2024

Conversation

lazappi
Copy link
Collaborator

@lazappi lazappi commented Dec 12, 2024 •
edited
Loading

Related to: #128

Description

  • Add a install_lamindb() function
  • Add a .onLoad() function that sets the default Python environment
  • Move {reticulate} to Imports
  • Add a lamin_connect() function that calls lamin connect
  • Add a lamin_login() function that calls lamin login
  • Add a set up vignette and updates other docs to use new functions
  • Update CI to use R setup functions

Checklist

Before review

  • Update and regenerate man pages
  • Add/update tests
  • Add/update examples in vignettes
  • Pass CI checks

Before merge

  • Update architecture vignette
  • Update development vignette
  • Update features in README
  • Update CHANGELOG

@lazappi lazappi marked this pull request as ready for review December 17, 2024 07:45
@lazappi lazappi requested a review from rcannood December 17, 2024 07:45
rcannood
rcannood approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@falexwolf falexwolf changed the title ✨ Improve Python setup 🚸 Improve the user experience around the Python setup for reticulate Dec 19, 2024
@falexwolf falexwolf changed the title 🚸 Improve the user experience around the Python setup for reticulate 🚸 Improve the user experience for setting up reticulate/Python Dec 19, 2024
@falexwolf falexwolf changed the title 🚸 Improve the user experience for setting up reticulate/Python 🚸 Improve the user experience for setting up Python & reticulate Dec 19, 2024
falexwolf
falexwolf reviewed Dec 19, 2024
View reviewed changes
DESCRIPTION Show resolved Hide resolved
falexwolf
falexwolf requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@falexwolf falexwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! ❤️

Just one mini change request for the docs! :)

README.md Outdated Show resolved Hide resolved
vignettes/setup.Rmd Show resolved Hide resolved
@lazappi lazappi merged commit a555bf2 into main Dec 20, 2024
7 checks passed
@lazappi lazappi deleted the issue-128/improve-python-setup branch December 20, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falexwolf falexwolf falexwolf requested changes

@rcannood rcannood rcannood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lazappi @rcannood @falexwolf