Add get_records() to API and df() to Registry #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazappi
commented
Oct 18, 2024
Comment on lines
+94
to
+98
| # Hacky way of avoiding unneeded requests until there is an easy way | ||
| # to get the total number of records | ||
| if (isTRUE(attr(.data_list, "finished"))) { | ||
| return(.data_list) | ||
| } |
There was a problem hiding this comment.
If there is a way to get the total number of records we can use a regular purrr::map instead
rcannood
requested changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
get_records()method to theInstanceAPIclass which performs the API call to retrieve record summary information and adf()method to theRegistryclass which makes the required API calls to get the requested number of records and formats the returned information as adata.frame(). This tries to be semi-smart to limit the number of API calls.Fixes #43
Checks:
CHANGELOG