fix: don't compare metadata in merge insert to detect if partial schema #3412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
approved these changes
Jan 23, 2025
| @@ -415,6 +415,8 @@ impl MergeInsertJob { | |||
| SchemaComparison::Subschema => true, | |||
| }; | |||
|
|
|||
| dbg!(add_row_addr); | |||
There was a problem hiding this comment.
I'm sure clippy will make you clean this up
There was a problem hiding this comment.
Shame on me for skipping self-review
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3412 +/- ##
==========================================
- Coverage 78.69% 78.67% -0.02%
==========================================
Files 250 250
Lines 90879 90934 +55
Branches 90879 90934 +55
==========================================
+ Hits 71517 71546 +29
- Misses 16419 16438 +19
- Partials 2943 2950 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.