Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): loosen bytemuck pin #3413

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

wjones127
Copy link
Contributor

We were pinned to an exact version, which caused issues for users of LanceDB lancedb/lancedb#2043

✅ I've run tests with bytemuck = "=1.14.0"

@github-actions github-actions bot added bug Something isn't working python labels Jan 23, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (aae351b) to head (51f8980).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3413      +/-   ##
==========================================
- Coverage   78.69%   78.68%   -0.02%     
==========================================
  Files         250      250              
  Lines       90899    90899              
  Branches    90899    90899              
==========================================
- Hits        71532    71522      -10     
- Misses      16424    16435      +11     
+ Partials     2943     2942       -1     
Flag Coverage Δ
unittests 78.68% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjones127 wjones127 merged commit a3434ca into lancedb:main Jan 23, 2025
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants