Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add testing of string/binary to 2.1 full-zip encoding and fix bugs #3418

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

westonpace
Copy link
Contributor

The bugs mostly originated from having def information but no rep information since the variable full zip path was originally built to support lists.

@github-actions github-actions bot added the enhancement New feature or request label Jan 27, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 65.76577% with 38 lines in your changes missing coverage. Please review.

Project coverage is 78.80%. Comparing base (58c5e27) to head (83859d1).

Files with missing lines Patch % Lines
rust/lance-encoding/src/repdef.rs 49.05% 27 Missing ⚠️
.../lance-encoding/src/encodings/logical/primitive.rs 81.13% 10 Missing ⚠️
rust/lance-encoding/src/testing.rs 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3418      +/-   ##
==========================================
- Coverage   78.81%   78.80%   -0.02%     
==========================================
  Files         250      250              
  Lines       91306    91365      +59     
  Branches    91306    91365      +59     
==========================================
+ Hits        71963    71998      +35     
- Misses      16390    16409      +19     
- Partials     2953     2958       +5     
Flag Coverage Δ
unittests 78.80% <65.76%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace merged commit 66b99fb into lancedb:main Jan 28, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants